Add port for NETX use #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for NETX by introducing NETX-specific macros, new fields in the SocketContext, and backend functions for handling socket operations via NETX. It also adds conditional compilation to allow external MQTT TLS callback implementations.
- Added NETX configuration and macro definitions in mqttport.h.
- Extended SocketContext with NETX fields and implemented NETX backend functions in mqttnet.c.
- Adjusted compilation conditionals for MQTT TLS in mqttexample.h and mqttexample.c.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/mqttport.h | Added NETX-specific include and macro definitions. |
| examples/mqttnet.h | Extended SocketContext with NETX-related members. |
| examples/mqttnet.c | Introduced NETX backend functions (disconnect, connect, write, read) and adjusted socket initialization. |
| examples/mqttexample.h | Added conditional exclusion based on EXTERNAL_MQTT_TLS_CALLBACK. |
| examples/mqttexample.c | Modified TLS callback conditional compilation. |
JacobBarthelmeh
assigned wolfSSL-Bot and JacobBarthelmeh and unassigned JacobBarthelmeh and wolfSSL-Bot
dgarske
previously approved these changes
May 27, 2025
|
I noticed an issue with handling socket timeout cases with this port. Adding a commit to fix it then reassigning back. |
embhorn
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds example port for NETX use and adds the macro EXTERNAL_MQTT_TLS_CALLBACK for compiling out the example TLS callback function.